Added UTs for resourceregistry in pkg/generated #5417
Conversation
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/L
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5417 +/- ##
==========================================
+ Coverage 30.12% 30.60% +0.48%
==========================================
Files 632 632
Lines 43936 43936
==========================================
+ Hits 13236 13448 +212
+ Misses 29742 29510 -232
- Partials 958 978 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@XiShanYongYe-Chang Please help review this MR too . |
|
Hey @yashpandey06 can you please update the file name from resourceregistry.go_test.go to resourceregistry_test.go. |
Apologies for that , fixed it |
|
we can move ahead with the review part |
|
Hi @yashpandey06 Can you help complete the title, and help squash the commits into one? |
|
/assign |
|
@XiShanYongYe-Chang sure doing it |
yashpandey06
changed the title
yashpandey06
changed the title
yashpandey06
changed the title
karmada-bot
added
the
do-not-merge/contains-merge-commits
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ions Signed-off-by: Yash Pandey <[email protected]> Added UTs for resourceregistry for better coverage of critical conditions Signed-off-by: Yash Pandey <[email protected]>
yashpandey06
force-pushed
the
test/generated/listers/search/v1alpha1/resourceregistry
branch
from
3cb6b41 to
d9ffb9a
Compare
karmada-bot
removed
the
do-not-merge/contains-merge-commits
|
|
@XiShanYongYe-Chang , commits have been squashed , i think we can proceed 🙂 |
There was a problem hiding this comment.
Hi @yashpandey06 the pkg/generated is automatically generated by the code generation tool, so I'm not sure that adding tests for them is necessary. I looked at the kubernetes repository and they don't have test files either.
@XiShanYongYe-Chang so should i close this pr instead ? |
Let's close it first. |
Thanks for your feedback, closing it now . |
/kind feature
Fixes part of #5236
Description
This PR introduces comprehensive unit tests for the
ResourceRegistryListerimplementation in thev1alpha1package. The tests cover the following scenarios:List Method:
ResourceRegistryobjects when the indexer is populated.Get Method:
NotFounderror is returned.ResourceRegistryobjects.These tests aim to ensure robustness and reliability of the
ResourceRegistryListerfunctionality by covering both typical and edge cases.Changes
TestResourceRegistryLister_Listto test theListmethod.TestResourceRegistryLister_Getto test theGetmethod, including error handling.mockIndexerto simulate error scenarios.Does this PR introduce a user-facing change?:
NONE